various unsigned byte bugfixes.

techascent · Sep 12, 2019 · 82f6781 · 82f6781
1 parent 11b6fa8
commit 82f6781
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/tech/v2/datatype/casting.clj b/src/tech/v2/datatype/casting.clj
@@ -290,7 +290,7 @@
   "Get a jvm datatype wide enough to store all values of this datatype"
   [dtype]
   (case dtype
-    :uint8 :int32
+    :uint8 :int16
     :uint16 :int32
     :uint32 :int64
     :uint64 :int64

diff --git a/src/tech/v2/datatype/typed_buffer.clj b/src/tech/v2/datatype/typed_buffer.clj
@@ -70,7 +70,8 @@
 
   dtype-proto/PToArray
   (->sub-array [item]
-    (dtype-proto/->sub-array backing-store))
+    (when (= datatype (dtype-proto/get-datatype backing-store))
+      (dtype-proto/->sub-array backing-store)))
   (->array-copy [item]
     (if (= datatype (dtype-proto/get-datatype backing-store))
       (dtype-proto/->array-copy backing-store)

diff --git a/test/tech/v2/datatype_test.clj b/test/tech/v2/datatype_test.clj
@@ -302,3 +302,11 @@
   (is (= (vec (range 200 255))
          (-> (dtype/make-container :list :uint8 (range 200 255))
              dtype/->vector))))
+
+
+(deftest desc-stats-unsigned-types
+  (is (= {:min 0.0
+          :max 255.0}
+         (-> (dtype/make-container :typed-buffer :uint8 (range 256))
+             (dfn/descriptive-stats)
+             (select-keys [:min :max])))))