Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign footer #81

Closed
laisfrigerio opened this issue Sep 30, 2021 · 7 comments · Fixed by #83
Closed

Redesign footer #81

laisfrigerio opened this issue Sep 30, 2021 · 7 comments · Fixed by #83
Assignees

Comments

@laisfrigerio
Copy link

Describe the solution you'd like
I would like to purpose a redesigned to footer

Describe alternatives you've considered

Additional context
For example:
funwithfisica-footer-redesign

  • Using green color (from logo) instead of yellow;
  • Added more spacing between elements;
  • Changing box-shadow from social network buttons;
  • Adding border around input elements;
  • other? Please, suggest :)
@welcome
Copy link

welcome bot commented Sep 30, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@github-actions
Copy link

Hi 😄, @laisfrigerio Thanks for creating an issue at FunwithPhysics. We request you to follow the contributing guidelines.

@Amit366
Copy link
Collaborator

Amit366 commented Sep 30, 2021

@laisfrigerio see the present footer is perfect as it was changed 3 to 4 times but if u want u can just change the color to green and add more spacing and nothing else.

@Amit366
Copy link
Collaborator

Amit366 commented Sep 30, 2021

You can check out other issues and work on them else if u wish u can add any other feature.

@laisfrigerio
Copy link
Author

Change de color and spacing:

funwithfisica-footer-redesign-2

@Amit366
Copy link
Collaborator

Amit366 commented Sep 30, 2021

@laisfrigerio yeah cool but don't send the PR now as there are already 3 pending PRs which will be cleared tomorrow, so u need to update ur cloned repo. After that u can send the PR.

@laisfrigerio
Copy link
Author

@Amit366 Okay. I will participate in Hacktoberfest too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants