Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install cleanup #61

Closed
hannesdelbeke opened this issue Mar 3, 2023 · 5 comments
Closed

pip install cleanup #61

hannesdelbeke opened this issue Mar 3, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@hannesdelbeke
Copy link
Collaborator

pip instal cleanup

original convo

Hannes
BQT discussion
IMO the current setup that auto adds files to your blender install is dirty.
After installing bqt, your vanilla blender changed, and when uninstalling it doesn't clean up.
e.g. when used in a studio pipeline, you might want your own startup file instead.
and when not running bqt, there now is a leftover startup file from bqt that will run.
Would this be a bad idea if we changed to this:
pip install bqt adds a py-module, nothing else. keep vanilla blender clean.
if the user needs/wants to add it to startup, they can run

import bqt
bqt.install_startup()

Frieder Erdmann
yes, its also bad because it breaks if you install bqt to a virtual environment

Chris Cunningham
ah that is pretty bad then, i tend to just assume a venv for python stuff

Dominic Noble
Not requiring to add it to Blender's site-packages would be super useful, I've had to make some very specific workaround for a deployment tool I'm making just for BQT.

Bob White
I think part of the issue when we first put it together was blender didn't make it super easy to ensure that binaries were installed on PATH in a way that the dlls would be found.
From what I remember, most of those issues have been dealt with at this point, so its possible the current installation process is just a weird legacy quirk

Bob White
Or it might have been a byproduct of me using pywin32 and it being weird as hell to install now that I think about it.

Greg Amato
Definitely byproduct of pywin32

@hannesdelbeke
Copy link
Collaborator Author

believe this is solved now. pip install wont auto add to startup anymore. instead bqt can now be loaded as an addon. which handles startup. and prevents poluting of vanilla blender install folder

@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented Apr 6, 2023

noticed the setup.py still contains ref too dist/bqt_startup.py

  • remove this
  • make local package and test install
  • release github package and test pypi build action, now that the secrets are hooked up

@hannesdelbeke hannesdelbeke reopened this Apr 6, 2023
@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented May 30, 2023

adding ref to blender pip. https://github.com/hannesdelbeke/blender_pip
since we handle clean blender pip installs there

@hannesdelbeke hannesdelbeke added the enhancement New feature or request label Jun 5, 2023
@hannesdelbeke
Copy link
Collaborator Author

  • removed dist/bqt_startup.py from setup.py
  • tested pip install
  • made first release https://github.com/techartorg/bqt/releases/tag/1.0.0
  • action to auto build and upload pypi package worked
  • noticed bqt_demo is also included in the pip install? not sure if we want that. likely cause we use setuptools.find_packages()

@hannesdelbeke
Copy link
Collaborator Author

bqt demo has been removed from package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant