Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech.v3.libs.nettoolkit #344

Closed
harold opened this issue Jan 11, 2023 · 4 comments
Closed

tech.v3.libs.nettoolkit #344

harold opened this issue Jan 11, 2023 · 4 comments

Comments

@harold
Copy link
Contributor

harold commented Jan 11, 2023

(:require [org.httpkit.client :as http]

This ns requires http-kit, but afaict http-kit is not included in this project.

I also don't see anyone that include this ns (tech.v3.libs.nettoolkit).

Not urgent, obviously, but what's this ns about?

it produces some stacktrace during docs build:

Could not generate clojure documentation for tech.v3.libs.nettoolkit - root cause: clojure.lang.Compiler$CompilerException Syntax error macroexpanding at (tech/v3/libs/nettoolkit.clj:1:1).
Syntax error macroexpanding at (tech/v3/libs/nettoolkit.clj:1:1).
	at clojure.lang.Compiler.load(Compiler.java:7665)
...
Caused by: java.io.FileNotFoundException: Could not locate org/httpkit/client__init.class, org/httpkit/client.clj or org/httpkit/client.cljc on classpath.
	at clojure.lang.RT.load(RT.java:462)
...
@cnuernber
Copy link
Collaborator

It was binding to nettookit which gives you geocoding of addresses - It is useful code but it is in source control - I think I should remove it from the project.

@harold
Copy link
Contributor Author

harold commented Jan 11, 2023

Oh, I see, that is interesting. Yes, perhaps it should be a separate lib.

@cnuernber
Copy link
Collaborator

Baleeted

@harold
Copy link
Contributor Author

harold commented Jan 12, 2023

(:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants