Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

left-join fails when options argument is nil #384

Closed
genmeblog opened this issue Oct 25, 2023 · 2 comments
Closed

left-join fails when options argument is nil #384

genmeblog opened this issue Oct 25, 2023 · 2 comments

Comments

@genmeblog
Copy link

When options are passed as nil instead of empty map {} left-join fails.

The main reason is this line: https://github.com/techascent/tech.ml.dataset/blob/master/src/tech/v3/dataset/join.clj#L346 which imho should be (assoc options :lhs-missing? true)
@genmeblog genmeblog changed the title left-join fails when options are nil left-join fails when options argument is nil Oct 25, 2023
@cnuernber
Copy link
Collaborator

right join had the same issue - what an odd mistake to make...

@genmeblog
Copy link
Author

Yes, yes, indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnuernber @genmeblog