Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AttributeObserverTrait #174

Closed
wagnert opened this issue Mar 23, 2020 · 1 comment
Closed

Refactor AttributeObserverTrait #174

wagnert opened this issue Mar 23, 2020 · 1 comment
Labels
enhancement
Projects
Pacemaker Community
Milestone
16.0.0

Comments

@wagnert
Copy link
Member

wagnert commented Mar 23, 2020

The trait has to be refactored and the functionality to initialize the cleanUpEmptyColumnKeys array has to be extracted from the clearRow() method to the implementing observer's factory method. This results in the fact, that each observer that handles attributes MUST implement the ObserverFactoryInterface.
@wagnert wagnert added this to the 16.0.0 milestone Mar 23, 2020
@wagnert wagnert self-assigned this Mar 23, 2020
@wagnert wagnert added this to ToDo in Pacemaker Community Apr 8, 2020
@wagnert wagnert moved this from ToDo to Selected in Pacemaker Community Apr 8, 2020
@wagnert wagnert removed their assignment Apr 8, 2020
@wagnert wagnert moved this from Selected to In Progress in Pacemaker Community Apr 29, 2020
@wagnert
Copy link
Member Author

wagnert commented Apr 29, 2020

Not possible, because at observer initialization time either row nor headers have been initialized.

@wagnert wagnert closed this as completed Apr 29, 2020
@wagnert wagnert moved this from In Progress to Done in Pacemaker Community Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Pacemaker Community
  
Done
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@wagnert