New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using http pipelining #8376

Closed

waghanza opened this issue Aug 24, 2023 · 3 comments

Contributor

waghanza commented Aug 24, 2023

Hi,

I can see in https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/wrk/query.sh#L10 that http pipelining is used here.

As I understand, http pipelining is disabled on major browsers
https://developer.mozilla.org/en-US/docs/Web/HTTP/Connection_management_in_HTTP_1.x#http_pipelining

And not sure if pipelining is made when a server-side API is consumed by an API (not browser).

I'm interested in why this feature is enabled on wrk.

Regards,

The text was updated successfully, but these errors were encountered:

Contributor Author

waghanza commented Aug 24, 2023

Related to the-benchmarker/web-frameworks#6623

Contributor

fakeshadow commented Aug 24, 2023 •

edited

I don't see where pipeline is used in the shell you referenced. With wrk you need -s or --script argument and a lua script to enable pipeline.
See https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/wrk/pipeline.sh#L31 and https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/wrk/pipeline.lua for usage.

Contributor Author

waghanza commented Aug 24, 2023

Sorry, I think I am confused between keeping alive, and http pipelining

waghanza closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment