support form input value, removing attributes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please pull the latest version - it supports removing attributes such as disabled, and generally setting any javascript property of a DOM element (selectedIndex, disabled, checked, etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted a small app from a self-submitting iframe that did all rendering on the server to an Espresso app. (Ended up ~150 lines coffeescript compiled to >300 lines javascript.) I needed the features added here to properly handle form elements, especially removing a disabled attribute once it was added and setting the value of form elements (selects are much easier to set this way, textareas can only be set this way).
I think there's a case to be made for supporting false as well as null for attribute removal, as I can't think of any circumstance in which I would set an attribute to boolean false and want the result to be attribute="false", but I didn't make that further change.