Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_base_dir false positives #175

Closed
dpw opened this issue Mar 21, 2011 · 1 comment
Closed

git_base_dir false positives #175

dpw opened this issue Mar 21, 2011 · 1 comment

Comments

@dpw
Copy link

dpw commented Mar 21, 2011

Background: I keep my home dir in git, which means that I have a ~/.git dir. But not all the dirs under my home dir are in git (many subtrees of my home dir are excluded in ~/.gitignore). Some ruby projects under my home dir are in mercurial, some are bare dirs.

In Jeweler::Specification, set_jeweler_defaults will always chdir to git_base_dir, assuming that is the root of the ruby project. So unless my ruby project is in git, git_base_dir will find my home dir, with predictably useless results.

As a resolution, I guesst that there should be some way when invoking Jeweler::Tasks.new from a Rakefile to set the actual base dir and to disable the git support.

@flajann2
Copy link
Collaborator

This is old and so closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants