Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movements may not work as expected with non-integer inputs #82

Open
oskay opened this issue Oct 14, 2016 · 3 comments
Open

Movements may not work as expected with non-integer inputs #82

oskay opened this issue Oct 14, 2016 · 3 comments

Comments

@oskay
Copy link
Collaborator

oskay commented Oct 14, 2016

Scratch API:
A user reports that the machine may not be correctly responsive when controlled in scratch/snap if the movement values are non-integer. In other words, that we may need to add an integer cast or rounding to the input values.

Needs verification.

@techninja
Copy link
Owner

Interesting! Will test, verify and fix.

@tieandjeans
Copy link

Hey! That was my issue last year! I don't think the issue was necessarily integer handling in CNCserver, rather generating small moves from WCBlocks that didn't clear the step threshold.

@oskay
Copy link
Collaborator Author

oskay commented Aug 22, 2017

Interesting-- yes, we could do this within WaterColorBlocks, but the API also needs to withstand this input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants