Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in api breaks other gems #13

Closed
rojoko opened this issue Mar 30, 2016 · 2 comments
Closed

change in api breaks other gems #13

rojoko opened this issue Mar 30, 2016 · 2 comments

Comments

@rojoko
Copy link

rojoko commented Mar 30, 2016

The change in the api to create a password from version 0.1.4 to 1.0.0 in https://github.com/technion/ruby-argon2/blob/master/lib/argon2.rb from #hash to #create breaks the devise-argon2 gem erdostom/devise-argon2#3 .

@rojoko
Copy link
Author

rojoko commented Mar 30, 2016

I read up now why you changed the API ( #9 ) and I hope the devise-argon2 will include your changed API.

@rojoko rojoko closed this as completed Mar 30, 2016
@technion
Copy link
Owner

Hi Rojoko,

I would encourage any dependant gem to correctly configure those dependencies around semantic versioning, so that breaking changes moving from 0.1.4 to 1.0.0 don't automatically propagate upwards.

Edit: I note you included such a fix within the PR you sent there. The fact that wasn't in place previously is the real issue here.

I would also urge you to review this statement in the README in relation

It is strongly advised to avoid implementations that utilise off-spec methods of introducing salts, invent imaginary parameters, or which use the word "encryption" in describing the password hashing process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants