Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bar] Round single side #168

Closed
techniq opened this issue May 29, 2024 · 1 comment
Closed

[Bar] Round single side #168

techniq opened this issue May 29, 2024 · 1 comment

Comments

@techniq
Copy link
Owner

techniq commented May 29, 2024

visx has a BarRounded component that does this, leveraging a <path> instead of a <rect>. I've debated on whether this should be a separate component, or if LayerChart's would switch between these underlying elements based on the props used.

Pros of single component:

  • Easier to use (just pass different props)

Cons of single component:

  • How to handle tweening the width/height when using <path> (what <Rect> provides)?
@techniq
Copy link
Owner Author

techniq commented May 30, 2024

Resolved via #169

@techniq techniq closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant