Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support react-custom-scrollbars #34

Open
serle opened this issue Jun 13, 2018 · 2 comments
Open

Feature Request: Support react-custom-scrollbars #34

serle opened this issue Jun 13, 2018 · 2 comments

Comments

@serle
Copy link

serle commented Jun 13, 2018

Please could you consider supporting react-custom-scrollbars on your menu

@techniq
Copy link
Owner

techniq commented Jun 24, 2018

I've not used it myself but would be open to trying to support it. I don't envision bringing the dependency in directly, but if we can allow a way to wrap Menu to support this, I don't see why not.

A quick search shows that integrating react-virtualized and react-custom-scrollbars might require a little additional effort:

The comments towards the bottom if 692 seem to show some working examples.

I've been keeping an eye on @bvaughn's new react-window (rewrite of react-virtualized) so whatever we come up with I'd like to make sure it doesn't hinder switching over to it at some point. I'm awaiting for some features to be ported over before I can take a hard look at it though.

@mpaccione
Copy link

I will be looking forward to this as well. I have a virtualized Table with a scroll bar and unfortunately I cannot have a cross browser solution with CSS. Tried implementing from the linked comments to no avail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants