Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add linting checks and unit tests to repo #50

Open
tgrowden opened this issue Aug 19, 2018 · 1 comment
Open

Feature Request: Add linting checks and unit tests to repo #50

tgrowden opened this issue Aug 19, 2018 · 1 comment

Comments

@tgrowden
Copy link
Contributor

@techniq When working on #48, I noticed a couple of things that I thought could improve the repo:

  • You have a .eslintrc, but there's no lint script in package.json, nor is any linting being done via CI. Several lint errors have made their way into the codebase.
  • There are no unit tests.

If you think adding these features would be beneficial, I'd be happy to get the ball rolling.

@techniq
Copy link
Owner

techniq commented Aug 19, 2018

@tgrowden That would be great. In my visual repos I've typically just leverage react-storybook but it doesn't catch visual regressions, etc (without manual testing, etc).

For my other repos, my testing stack is typically jest with react-testing-library, and I'll use fetch-mock if I need to mock out some requests. You can see my setup for another project here.

I wouldn't mind adding prettier as part of the workflow as well (I run it locally on save, but it would be nice to have it ran on git stage, etc). Something like this.

As always, any help is very much appreciated. I've been working on a big update for mui-table this weekend and typically my open source is driven by my need in private projects, but I like to open source / support what I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants