Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Whatsapp #21

Merged
merged 1 commit into from Aug 26, 2021
Merged

Adding Whatsapp #21

merged 1 commit into from Aug 26, 2021

Conversation

MarioGK
Copy link
Contributor

@MarioGK MarioGK commented Aug 23, 2021

Hi just a simple pull request to add Whatsapp, i think i did everything correct if not please tell me

@timothystewart6
Copy link
Contributor

Hey! Thank you! It looks like you've changed some of the formatting. Any way you can update this PR to only include the necessary changes for WhatsApp? Thank you!

@MarioGK
Copy link
Contributor Author

MarioGK commented Aug 24, 2021

Oh sorry I didn't notice, I will fix it tomorrow

@timothystewart6
Copy link
Contributor

No worries! Thank you so much!

@timothystewart6
Copy link
Contributor

@MarioGK If you have some time, any way you can update this? I have a v2 PR out there that will change how contributions work and this PR wouldn't be able to be merged into v2. I'd love to get this in.

@timothystewart6
Copy link
Contributor

If not, no worries, just wanted to check

@timothystewart6
Copy link
Contributor

T did merge this in but since it moved to reactjs I will open a PR and use that as an example. Thank you!

@MarioGK
Copy link
Contributor Author

MarioGK commented Aug 26, 2021

Sorry I didn't have the time to do that today, no worries I will make a pull request adding it to v2 the react version

@timothystewart6
Copy link
Contributor

@MarioGK no worries, I did it for you for v2! I merged this one, then created a PR based on it to update it. #23 Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants