Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Reliability improvements #36

Merged
merged 20 commits into from Jan 5, 2023
Merged

[WIP] Reliability improvements #36

merged 20 commits into from Jan 5, 2023

Conversation

hulthe
Copy link
Collaborator

@hulthe hulthe commented Dec 28, 2022 •
edited

  • Fix AsyncDrop hanging when modem restarts
  • Fix AsyncDrop clean up logic
  • Add timeouts to all AT commands
  • Add timeouts to modem power
  • Add timeouts to TCP connect
  • Clean up connection if TCP connect errors
  • Use non-blocking channels to send ConnectionMessages
  • Improve handling of unexpected ConnectionMessages
  • Add timeouts to waiting for registration
  • Purge windows line endings
  • Make line reader only look for \n instead of \r\n (voltage warnings only ends with \n)
  • Add more docs
  • Other stuff

@hulthe
Move crate error to error.rs
ed4b5f8
@hulthe
Bump rust version
1ce37b5
@hulthe
Add PowerSignal struct
a714566
@hulthe
Make line reader look for only line feeds
1750598 
As opposed to carriage return, line feed.
@hulthe
Add timeout to AT commands
00cee33
@hulthe
Document drop.rs more
94335c6
@hulthe
Fix comment
ac40dff
@hulthe
Always run async drop clean_up
87bb3ba
@hulthe
Don't unnecessarily enable heapless defmt feature
910b71a
@hulthe
Derive Debug, even if defmt is enabled
724874c
@hulthe
Use let-else because it's cool
5a6ae9f
@hulthe
Fix line endings & clean up unused files
7019f58
@hulthe
Shut clippy up
8e065a8
@hulthe
Remove debugging defmt logs
29246ac
@hulthe
Avoiding hanging on connect_tcp
6d1ae1f
@hulthe
Make sure drop clean up always runs
1583fb0
@hulthe
Add timeout to modem power
efeeb4d
@hulthe
Avoid hanging when waiting for registration
e550ba0
@hulthe
Improve tcp connection reliability
4e95ffd 
* Make sure to clean up connection if there was an error when connecting
* Improve handling or unexpected connection messages
* Use a non-blocking channel to communicate connection messages
@hulthe
Add timeout to Gnss::get_report()
a2ea0d5
@hulthe hulthe merged commit a533eef into main Jan 5, 2023
@hulthe hulthe deleted the reliability-improvements branch January 5, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hulthe