Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign line reader #9

Merged
merged 1 commit into from Jan 3, 2022
Merged

Redesign line reader #9

merged 1 commit into from Jan 3, 2022

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jan 3, 2022

The current line reader was horribly broken. The redesign makes the
reader match the datasheet more closely. Insead of reading until \r\n
and returning all text up until then, the new reader finds the leading
\r\n that preceeds all sim7000 lines. It then reads up to the following
\r\n to terminate the line. This resolves intermittent issues with echo
as well as some unsolicited result codes.

The current line reader was horribly broken. The redesign makes the
reader match the datasheet more closely. Insead of reading until \r\n
and returning all text up until then, the new reader finds the leading
\r\n that preceeds all sim7000 lines. It then reads up to the following
\r\n to terminate the line. This resolves intermittent issues with echo
as well as some unsolicited result codes.
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #9 (8566e4c) into main (1dfaae3) will increase coverage by 1.50%.
The diff coverage is 67.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   35.02%   36.52%   +1.50%     
==========================================
  Files          32       32              
  Lines         748      720      -28     
==========================================
+ Hits          262      263       +1     
+ Misses        486      457      -29     
Impacted Files Coverage Δ
src/commands/ccid.rs 0.00% <ø> (ø)
src/commands/cgmr.rs 0.00% <ø> (ø)
src/commands/cgnscpy.rs 0.00% <ø> (ø)
src/commands/cgnsinf.rs 52.94% <ø> (+1.99%) ⬆️
src/commands/cgnspwr.rs 0.00% <ø> (ø)
src/commands/cgreg.rs 0.00% <ø> (ø)
src/commands/cipstart.rs 0.00% <0.00%> (ø)
src/commands/cipstatus.rs 0.00% <0.00%> (ø)
src/commands/cntp.rs 0.00% <ø> (ø)
src/commands/cops.rs 0.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfaae3...8566e4c. Read the comment docs.

@ZoeyR ZoeyR merged commit 8566e4c into main Jan 3, 2022
@ZoeyR ZoeyR deleted the redesign-decoder branch January 3, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant