Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Confusing readme #45

Closed
glensc opened this issue Oct 30, 2020 · 2 comments
Closed

Confusing readme #45

glensc opened this issue Oct 30, 2020 · 2 comments
Assignees
Projects

Comments

@glensc
Copy link

glensc commented Oct 30, 2020

the example in readme:

      - uses: 8398a7/action-slack@v2
        with:
          # status: ${{ env.WORKFLOW_CONCLUSION }} # neutral, success, cancelled, timed_out, failure
          status: failure
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
        if: env.WORKFLOW_CONCLUSION == 'failure' # notify only if failure

why the 'failure' check is declared twice?

  1. with status: failure
  2. if env.WORKFLOW_CONCLUSION == 'failure'

shouldn't it be sufficient to use only one of them?

@welcome
Copy link

welcome bot commented Oct 30, 2020

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@github-actions github-actions bot added this to To do in Backlog Oct 30, 2020
@technote-space
Copy link
Owner

Please use other action.

Backlog automation moved this from To do to Done Oct 30, 2020
Repository owner locked as spam and limited conversation to collaborators Oct 30, 2020
Repository owner unlocked this conversation Oct 30, 2020
Repository owner locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Backlog
  
Done
Development

No branches or pull requests

2 participants