Step coloring fixes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the substring was matched always from the beginning
- instead of substring search - match text with step definition regex - iterate all match groups and use their position
|
Thanks for the PR. |
|
@szaliszali Could you add an entry into the changelog? https://github.com/techtalk/SpecFlow.VisualStudio/blob/master/changelog.txt |
littlegenius666
pushed a commit
to littlegenius666/SpecFlow.VisualStudio
that referenced
this pull request
May 3, 2019
Related issue: SpecFlowOSS/SpecFlow#483 Notes: - this PR is still legacy code not backed by automated tests, but I think it was worth opening to highlight what's wrong with the current implementation - the fix may have some performance impact if there are complicated step definition patterns defined, because the regex must be matched a second time to get the correct positions - a more correct solution would be to change `StepDefinitionMatchService.GetBestMatch` in SpecFlow to return the positions instead of substrings where possible, but that would be way over budget considering that the VS extension is using an outdated version of SpecFlow internally Fix 1 (original issue): Before:  After:  Fix 2 (multiple occurrences of the same `<pattern>`): Before:  After: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: SpecFlowOSS/SpecFlow#483
Notes:
StepDefinitionMatchService.GetBestMatchin SpecFlow to return the positions instead of substrings where possible, but that would be way over budget considering that the VS extension is using an outdated version of SpecFlow internallyFix 1 (original issue):
Before:
After:
Fix 2 (multiple occurrences of the same
<pattern>):Before:
After:
