Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Consolidate all API calls into an api-client.js file #131

Open
vegetabill opened this issue Oct 6, 2020 · 2 comments
Open

[Refactor] Consolidate all API calls into an api-client.js file #131

vegetabill opened this issue Oct 6, 2020 · 2 comments
Labels
🛑 blocked Waiting on one or more issues to be merged good first issue Good for newcomers UI create an interface for the new save functionality.
Projects
Open-source issue board - Keyboard Sh...

Comments

@vegetabill
Copy link
Collaborator

With webpack support enabled by #94 we can now make our browser JavaScript better.

Please move all fetch calls currently in main.js into a new file called api-client.js.

That way we can consolidate all error handling and if the API call returns a 401 we will need to prompt the user to log back in.
@vegetabill vegetabill added Hacktoberfest UI create an interface for the new save functionality. good first issue Good for newcomers 🛑 blocked Waiting on one or more issues to be merged labels Oct 6, 2020
@vegetabill
Copy link
Collaborator Author

Blocked on #77 and #96 so all the API calls are there to move.

@y-martinez
Copy link
Contributor

Hi @vegetabill I know that this issue is blocked but I can work on this issue with the fetch calls already exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🛑 blocked Waiting on one or more issues to be merged good first issue Good for newcomers UI create an interface for the new save functionality.
Projects
Open-source issue board - Keyboard Sh...
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vegetabill @y-martinez @alodahl