Item PUT HTTP response - correction proposal

[csabaszeles]

rest-apis-flask-python/section6/resources/item.py

Lines 48 to 60 in 3380640

	def put(self, name):
	data = Item.parser.parse_args()
	item = ItemModel.find_by_name(name)
	if item:
	item.price = data['price']
	else:
	item = ItemModel(name, **data)
	item.save_to_db()
	return item.json()

Hi,
In Lec99, the HTTP response of PUT is not fully correctly dealt with. According to this: https://httpwg.org/specs/rfc7231.html, PUT should return 201, when new resource has been created.
(Also, added error handling similarly to the post() method)
So, I think implementation of put() should be appended with the HTTP response code handling, like this:

    def put(self, name):
        data = Item.parser.parse_args()
        item = ItemModel.find_by_name(name)

        # if item with name doesn't exist, we create it
        if item is None:
            item = ItemModel(name, **data)
            http_status_code = 200
        else:
            item.price = data["price"]
            http_status_code = 201

        try:
            item.save_to_db()
        except:
            return {"message": "An error occurred upserting the item."}, 500

        return item.json(), http_status_code

Best,
Csb

[jslvtr]

Thank you for this! Since we have updated the entire course content, I'll close this for now.