Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide high-level interface to set favicon #3

Open
Tectu opened this issue Aug 19, 2022 · 0 comments
Open

Provide high-level interface to set favicon #3

Tectu opened this issue Aug 19, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tectu
Copy link
Owner

Tectu commented Aug 19, 2022

Provide a high-level interface (most likely in zim::controller) to set a favicon.

This function should accept a filesystem path to the corresponding favicon.ico file and automatically register the corresponding GET /favicon.ico endpoint.

Alternatively, a filesystem path could be provided to the controller configuration (zim::controller::configuration). Upon initialization of the controller (zim::controller::init()) the controller could check whether a valid filepath was provided and create the corresponding GET /favicon.ico endpoint as needed.

@Tectu Tectu added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant