fix: new separator always added to default location (close #44)

teddy-gustiaux · Apr 30, 2019 · 5609cae · 5609cae
1 parent e8ceeb2
commit 5609cae
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/background/bookmarking/BuiltinBookmarking.js b/src/background/bookmarking/BuiltinBookmarking.js
@@ -72,6 +72,7 @@ class BuiltinBookmarking {
 
     async move(id, bookmarkInfo) {
         if (!this._isSystemCreated(bookmarkInfo)) return;
+        if (Utils.bookmarkIsSeparator(bookmarkInfo)) return;
         let bookmarkTreeNode;
         if (Utils.bookmarkIsWebPage(bookmarkInfo)) {
             bookmarkTreeNode = this._createMovingPropertiesForBookmark();

diff --git a/src/background/utils/Utils.js b/src/background/utils/Utils.js
@@ -64,6 +64,18 @@ class Utils {
     // BOOKMARKS
     // -------------------------------------------------------------------------------------------------
 
+    // Indicate if a bookmark object is a separator
+    static bookmarkIsSeparator(bookmarkInfo) {
+        let isSeparator = false;
+        if (
+            Object.prototype.hasOwnProperty.call(bookmarkInfo, 'type') &&
+            bookmarkInfo.type === 'separator'
+        ) {
+            isSeparator = true;
+        }
+        return isSeparator;
+    }
+
     // Indicate if a bookmark object is a web page
     static bookmarkIsWebPage(bookmarkInfo) {
         let isWebPage = false;