Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug visualization on samsung s6/s6 email app #48

Closed
metalgigio opened this issue Apr 15, 2016 · 8 comments
Closed

Bug visualization on samsung s6/s6 email app #48

metalgigio opened this issue Apr 15, 2016 · 8 comments
Labels
bug something in the original template doesn't display correctly

Comments

@metalgigio
Copy link

I'm italian so i'm sorry for my english.
I've discovered that hybrid template have an ugly right band when viewing on samsung s6/s7 email app.
I've made some test and i've also discovered that changing:

html,
body {
            margin: 0 !important;
            padding: 0 !important;
            height: 100% !important;
            width: 100% !important;
        }

to

html,
body {
            padding: 0 !important;
            height: 100% !important;
            width: 100% !important;
        }

solved the issue.
Hope it can help

@TedGoas TedGoas added the bug something in the original template doesn't display correctly label Apr 15, 2016
@TedGoas
Copy link
Owner

TedGoas commented Apr 15, 2016

@metalgigio thanks so much for flagging this? Any chance you have before / after screenshots?

@TedGoas
Copy link
Owner

TedGoas commented Apr 18, 2016

@metalgigio Thanks so much for uncovering a bug. I don't have a samsung s6/s7 email app to test on. I tested the code above but found that it breaks the margins on the Android 4.4 stock email browser. Have you experienced this?

android4-vertical-allowed-1366

@metalgigio
Copy link
Author

Hi,
i will post a screenshot asap.

@metalgigio
Copy link
Author

Before:

screenshot_20160418-092253

After:

screenshot_20160418-092331

@TedGoas
Copy link
Owner

TedGoas commented Apr 18, 2016

@metalgigio thanks for pointing this out. I did some testing and found only resetting the body margin is necessary, so I separated html and body resets. Please let me know if your issue persists.

@metalgigio
Copy link
Author

Hi, the solution u provide did not solve the bad visualizzation on s6/s7.

@TedGoas TedGoas reopened this Apr 19, 2016
@TedGoas
Copy link
Owner

TedGoas commented Apr 19, 2016

@metalgigio Does this code fix it on your device?

Change this:
html, body { margin: 0 !important; padding: 0 !important; height: 100% !important; width: 100% !important; }

to this:
body { margin: 0 auto !important; padding: 0 !important; height: 100% !important; width: 100% !important; }

@metalgigio
Copy link
Author

Yes, it works.
i've even tried this code that works correctly too:

html, body { margin: 0 auto !important; padding: 0 !important; height: 100% !important; width: 100% !important; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something in the original template doesn't display correctly
Projects
None yet
Development

No branches or pull requests

2 participants