Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template-default 3 column issue #6

Closed
endofgeneric opened this issue Dec 18, 2014 · 3 comments
Closed

Template-default 3 column issue #6

endofgeneric opened this issue Dec 18, 2014 · 3 comments

Comments

@endofgeneric
Copy link

Hi there thanks for the awesome templates. First off, I'm a designer who is html/css savvy and not a developer. I'm having an issue with the 3-column section of the 'template-default' file.

I've removed the padding so the images touch the edge of the wrapper table and added placeholders that are 190px wide, looks fine in both regular and responsive layouts:
desktop

600px-moretextcontent

Funny thing is happening though when I remove text from the columns. For example, if I delete a sentence of the dummy copy, I get a gap on the right hand side when I hit the 600px threshold to a responsive layout:

600px-lesstextcontent

It may be a simple solution but I can't work out what's breaking, any ideas? Here's the code I'm using for the section, all other code - css etc. - has been kept the same in the template:

  <tr>
    <td>
      <table border="0" cellpadding="0" cellspacing="0" class="columns-container">
        <tr>
          <td align="center" width="190" style="font-family: sans-serif; font-size: 16px; line-height: 22px;padding-right: 15px;color: #444444;" valign="top" class="force-col">
            <img src="3col-plchldr-190x220.jpg" alt="alt text" height="220" width="190" border="0" style="display: block;padding-bottom: 10px;" class="col-3-img-r">
            <a href="#" style="color:#444444; font-weight:bold; text-decoration: none; text-transform: uppercase;">header</a>
            <br>
            Saepe scaevola id has. Duo et regione albucius ponderum. Dicta definitiones sed ex.
          </td>
          <td style="font-size: 0; line-height: 0; display: none;" class="hh-spacer">&nbsp;</td>
          <td align="center" width="190" style="font-family: sans-serif; font-size: 16px; line-height: 22px; padding-right: 15px;color: #444444;" valign="top" class="force-col">
            <img src="3col-plchldr-190x220.jpg" alt="alt text" height="220" width="190" border="0" style="display: block; padding-bottom: 10px;" class="col-3-img-l">
             <a href="#" style="color:#444444; font-weight:bold; text-decoration: none; text-transform: uppercase;">header</a>
            <br>
            Saepe scaevola id has. Duo et regione albucius ponderum. Dicta definitiones sed ex.
            </td>
          <td style="font-size: 0; line-height: 0; display: none;" class="hh-spacer">&nbsp;</td>
          <td align="center" width="190" style="font-family: sans-serif; font-size: 16px; line-height: 22px;color: #444444;" valign="top" class="force-col">
            <img src="3col-plchldr-190x220.jpg" alt="alt text" height="220" width="190" border="0" style="display: block;padding-bottom: 10px;" class="col-3-img-r">
             <a href="#" style="color:#444444; font-weight:bold; text-decoration: none; text-transform: uppercase;">header</a>
            <br>
            Saepe scaevola id has. Duo et regione albucius ponderum. Dicta definitiones sed ex.
          </td>
        </tr>
      </table>
    </td>
  </tr>
  <!-- Three Column ==> Stacked Wide Layout ==> Stacked Narrow Layout : END -->

Thanks!

@TedGoas
Copy link
Owner

TedGoas commented Dec 28, 2014

@endofgeneric Cheers, glad you're getting some use out of the templates.

Hmmm, something could be missing from your version. I wonder if .columns-container isn't getting a 100% width. I also noticed that your screenshots have centered text as the layout narrows, whereas 'template-default' has left-justified text.

Can you double-check the original template against the code you removed to modify it?

@TedGoas
Copy link
Owner

TedGoas commented Jan 23, 2015

@endofgeneric Heya, I just released a new version of Cerberus. If you're still having trouble and can recreate the same issue above with the new code, can you please file a new bug? For now, I'm going to close this issue since the code your working with is moving towards deprecation.

If you have any questions, hit me up here or on Twitter @TedGoas.

@TedGoas TedGoas closed this as completed Jan 23, 2015
@endofgeneric
Copy link
Author

Thanks for the heads up Ted. I'll take a look at the updated version and let you know of any issues I have.

Thanks!

Michael Clayton

Sent from my iPhone

On 23 Jan 2015, at 01:45, Ted Goas notifications@github.com wrote:

@endofgeneric Heya, I just released a new version of Cerberus. If you're still having trouble and can recreate the same issue above with the new code, can you please file a new bug? For now, I'm going to close this issue since the code your working with is moving towards deprecation.

If you have any questions, hit me up here or on Twitter @TedGoas.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants