An empty file in the attachment generates false instead of the whole Message

[lkorczewski]

Replication

Trying to retrieve an email containing an attachment with an empty text file.

Result

false instead of object of class Message

When analyzed more closely, the false value arose from an exception:

protected 'message' => string 'Notice: Undefined property: stdClass::$bytes' (length=44)
private 'string' (Exception) => string '' (length=0)
protected 'code' => int 0
protected 'file' => string '/SOME_PATH/vendor/tedivm/fetch/src/Fetch/Attachment.php' (length=85)
protected 'line' => int 101

Notes

There is also one thing, while the declaration below:

/**
 * Returns the requested email or false if it is not found.
 *
 * @param  int          $uid
 * @return Message|bool
 */
public function getMessageByUid($uid)

says true -- it's Message or bool.

The declaration of getOrderedMessages does not:

/**
 * Returns the emails in the current mailbox as an array of ImapMessage objects
 * ordered by some ordering
 *
 * @see    http://php.net/manual/en/function.imap-sort.php
 * @param  int       $orderBy
 * @param  bool      $reverse
 * @param  int       $limit
 * @return Message[]
 */
public function getOrderedMessages($orderBy, $reverse, $limit)

beacause you may end up with an array including falses if there were any errors and that's misleading.