Fix undefined properties while retrieving message overview #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tedivm Any thoughts on this PR? |
|
Sorry, I've been traveling for work. I really won't have a chance to look this over until next week, but I will then. |
|
Oh, sorry, didn't want to interrupt ;) |
|
No worries, I just wanted to make sure you knew I wasn't ignoring you. |
|
wouldn't a property_exists(); be more accurate then isset() ? isset() returns false if the property is null. |
|
IMHO it's wayne. |
|
But I'm thinking about, to do this sanity check already in the @tedivm what do you think about it? |
|
closed in favour of new test suite, their changes and possible code breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix issue #21