New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apc Driver: Check for 'apc.enable_cli' in cli calls #368
Conversation
Can you confirm that this works as expected, both with and without APC enabled? |
I did test it locally both with and without |
Hm, is there anything I need to do to make Travis happy? I checked for tests of the Since |
@Biont - the test that's failing is the style check. You just need to fix the indentation on your code and it should pass. @alexbowers - feel free to merge this once it passes. |
@tedivm Is it the style? Could be worth splitting up between StyleCI and Travis CI for style and unit tests? |
Yeah, when I set the project up StyleCI didn't exist so I just added a test case in for styling. If you want to break that up that would be great. |
do you have a particular style guide you follow? (Eg. PSR etc)
…On 23 August 2017 at 22:24, Robert Hafner ***@***.***> wrote:
Yeah, when I set the project up StyleCI didn't exist so I just added a
test case in for styling. If you want to break that up that would be great.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#368 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAzc3sx0iYDiuk-kf284lklpr6rlF6g1ks5sbJiWgaJpZM4O9aAD>
.
|
Yeah- it's all in the contributing docs. |
2 similar comments
Thanks for the hint @tedivm I enabled PSR2 codesniffing for this project and should be good to go now, should there be future PRs |
As described in #365, Stash can currently run into a fatal error in specific circumstances.
This PR introduces a check in
Apc->isAvailable()
to let the driver fail early if APCu is not configured to run in CLI environments.