Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Timeout In Connection String #1256

Closed
dmshuttle opened this issue Jun 10, 2021 · 4 comments · Fixed by #1257
Closed

Request Timeout In Connection String #1256

dmshuttle opened this issue Jun 10, 2021 · 4 comments · Fixed by #1257

Comments

@dmshuttle
Copy link

dmshuttle commented Jun 10, 2021

According to documentation:

Documentation:
requestTimeout - Request timeout in ms (default: 15000). NOTE: msnodesqlv8 driver doesn't support timeouts < 1 second. When passed via connection string, the key must be request timeout

Expected behaviour:

"request timeout=30000;" should set request timeout to 30 secs

Actual behaviour:

"request timeout=30000;" will do nothing, "requesttimeout=30000;" will change timeout

Software versions

  • NodeJS: 12
  • node-mssql: 7.1.1
@dhensby
Copy link
Collaborator

dhensby commented Jun 10, 2021

Which version are you using? Please use the issue template.

@dmshuttle
Copy link
Author

The first post is updated with versions.

@dmshuttle
Copy link
Author

dmshuttle commented Jun 10, 2021

Also, I blame connection-pool.js, line 250
case 'requesttimeout':
Object.assign(config, {
requestTimeout: parseInt(value, 10)
})

@dhensby
Copy link
Collaborator

dhensby commented Jun 11, 2021

fixed in 7.1.2 7.1.3 - I was a bit hasty with the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants