Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolation level values clarification #482

Closed
davazp opened this issue May 29, 2017 · 1 comment
Closed

Isolation level values clarification #482

davazp opened this issue May 29, 2017 · 1 comment

Comments

@davazp
Copy link

davazp commented May 29, 2017

I would like to propose a clarification to the documentation of the begin method.

isolationLevel - Controls the locking and row versioning behavior of TSQL statements issued by a connection. Optional. READ_COMMITTED by default. For possible values see sql.ISOLATION_LEVEL.

It is not clear to me if that is a string READ_COMMITTED or the value of the sql.ISOLATION_LEVEL map.

I was using a string and I thought that worked, but I switched to the mssqlnodev8 driver and it complained with the error

Invalid isolation level.

So two improvements suggested:

  • Changing the begin example to show some isolation level would make it.
  • Make both drivers consistent, by throwing an error when the isolation level is unknown
@dhensby
Copy link
Collaborator

dhensby commented Mar 8, 2019

Documentation PR welcome

Closing due to age of issue, but PR would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants