Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre 2001 Dates throws Out of Range Error when using params #1599

Closed
LoreIsRobot opened this issue Feb 7, 2024 · 3 comments · Fixed by #1600
Closed

Pre 2001 Dates throws Out of Range Error when using params #1599

LoreIsRobot opened this issue Feb 7, 2024 · 3 comments · Fixed by #1600
Labels

Comments

@LoreIsRobot
Copy link

Software versions

  • Tedious: 16.7.0

Problem description
I'm using TypeOrm in a project and it all of a sudden started to fail to update with pre 2001 dates. I can see in the commit for 16.7.0 (19cb073) that the unit tests expect it to fail for 2000-12-31 (test/unit/data-type.js lines 218, 323, 388). There is an issue with the min date. I'll see if I can fix it, but wanted it out here at least in the meantime.

@arthurschreiber
Copy link
Collaborator

Hey, thanks for reporting this! ❤️

@MichaelSun90 will also look into it, in case you don't have the time to dig into the source code.

@LoreIsRobot
Copy link
Author

It appears that 'January 1, 0001' is being parsed as 2001. It's all over the board what Date is parsing things as though. Passing in integer values returns 1901 🤷. I've been using Dayjs now for a while, I'll need to refresh myself.

Copy link

github-actions bot commented Feb 9, 2024

🎉 This issue has been resolved in version 16.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants