feat(types): export ConnectionConfiguration type

[WikiRik]

Thanks for adding first-party typings! I've noticed that ConnectionConfiguration wasn't exported, while we are using that for sequelize here; https://github.com/sequelize/sequelize/blob/main/packages/core/src/dialects/mssql/connection-manager.ts (@types/tedious calls it ConnectionConfig but the object is basically the same as ConnectionConfiguration)

I went ahead and just exported the type here, but I'm open to hear if you have other suggestions on what type to use.

[arthurschreiber]

Cool, looks good to me! Will get it merged once I'm close to a computer.

[WikiRik]

I should have ran tests locally first, but exporting the type should also work. Let's hope CI is green now, otherwise I will run stuff locally

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.25%. Comparing base (1226c20) to head (7b4b75a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   78.43%   78.25%   -0.19%     
==========================================
  Files          93       93              
  Lines        4860     4860              
  Branches      934      934              
==========================================
- Hits         3812     3803       -9     
- Misses        751      757       +6     
- Partials      297      300       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

CI is mostly green, just codecov is mentioning that coverage has gone down. Feel free to let me know if you want me to add a test (and mention where)

[arthurschreiber]

CI is mostly green, just codecov is mentioning that coverage has gone down. Feel free to let me know if you want me to add a test (and mention where)

Coverage is very finicky - in this case we're adding a line of code that can't really be tested in any sensible way (remember type definitions are completely stripped at runtime which is when coverage is collected).

Coverage going down is not a problem. Thank you for preparing the change (and fixing the typo in the title lol 🤣).

[github-actions]

🎉 This PR is included in version 18.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀