-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tedious TVP, is a becoming blocking operation for large data #475
Comments
Yes, you're right, writing large TVP is currently a blocking operation. The main issue here is that before Fixing this would require a pretty big overhaul of the internals of |
:) Does a Bulk upload work in a similar fashion ? I basically need to send a large chunk of data to my SP. I am open to modify the working's if a Bulk upload would solve the problem |
Yeah, looks like bulk inserts work in a similar fashion. :( |
Making different aspects of tedious less blocking and more stream-oriented is one of my long term goals for |
Appreciate the effort, Arthur. Thanks |
Any update on this? If I wanted to investigate this myself where would I start? |
Ditto, would love to see a fix for this issue |
Putting some more thought into this. Would it be possible to add a setTimeout/nextTick in between packet writes to allow other processing to also take place and not completely block the event loop? If so where would be a likely spot for this to go? |
@arthurschreiber Looks like not, as you said above, the required changes would be pretty extensive. I am still interested in looking into this if you'd accept a PR but would likely need a little guidance for first steps. |
Hi @RajatBanerjee do you still get the same slow performance when using BULK INSERT Operations instead? As stated in the MSDN docs, "table-valued parameters perform well for inserting less than 1000 rows." |
🎉 This issue has been resolved in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I am trying to do a call a stored procedure with a TVP as a parameter . This TVP is built from a CSV, with ~ 30000 rows . When the request begins, the thread gets blocked and any request into the application is not handled .
I have tried calling a sp whihc internally sends the response back after a 5 mins delay, but in that case the operayionn is Async . This leads me to believe that the Sp call itself is not a blocking call, but the build up upto the sp call \ processing the data inside tedious is blocking
The text was updated successfully, but these errors were encountered: