Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireworks #14

Closed
CupidonSauce173 opened this issue Mar 25, 2019 · 7 comments
Closed

fireworks #14

CupidonSauce173 opened this issue Mar 25, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@CupidonSauce173
Copy link

could you make it so the dispenser works with fireworks too ? Since its not implemented in pmmp
it would use a plugin like https://github.com/thebigsmileXD/fireworks/tree/master/
as a not necessary depency

@DenielWorld
Copy link
Contributor

I believe it should already do that, since firework is a projectile and those are already inplemented.

@CupidonSauce173
Copy link
Author

Oh, so this is an issue. Fireworks doesn't work with dispenser

@DenielWorld
Copy link
Contributor

I might be able to add that myself, but there probably should be a config for it, since it will crash the server for those not using fireworks.

@CupidonSauce173
Copy link
Author

Yes please, you would be my lover ;).

@tedo0627 tedo0627 added the enhancement New feature or request label Mar 26, 2019
@dearminder
Copy link

how about adding a config to enable fireworks?

@LeoBdt
Copy link

LeoBdt commented Mar 27, 2019

Fireworks are implemented with teaspoon plugin

@tedo0627
Copy link
Owner

I implemented it.

This was referenced Apr 23, 2019
@zPqguro zPqguro mentioned this issue May 1, 2020
This was referenced Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants