Skip to content

Commit

Permalink
Sorting the FileS display grid would hide the KnownHash column. Now i…
Browse files Browse the repository at this point in the history
…t remains visible after multiple sorts
  • Loading branch information
tedsmith committed Jan 9, 2019
1 parent 2844513 commit 1d024b9
Show file tree
Hide file tree
Showing 8 changed files with 185 additions and 187 deletions.
18 changes: 13 additions & 5 deletions CHANGELOG.md
@@ -1,23 +1,31 @@
Version History
===============

v3.0.3 (Nov 2018)
v3.0.3 (Jan 2019)

The 'Load Hashlist' functionality in the 'FileS' tab would accept all values but then compare them against computer uppercase hashes strings, meaning any lowercase imported values were not matched.
Now all input is converted to uppercase first.

The 'Load Hashlist' functionality in the 'FileS' tab can now accept CSV saved files (but must still contain only one column of hash values!)

The 'Known Hash Flag' column, where it reports either YES or NO after importing a hash list, was only showing with the default display grid in FileS tab. If the user resorted, the column would vanish. Now it should remain for all sorting.

The filehandles were not always being released properly, even if hashing completed OK, thus leaving open handles to processed files. A bug I introduced by mistake in v3.0.2. by trying to free handles more gracefully! That was fixed. Report issues with this if still not working properly.

The 'FileS' tab was computing file hashes of zero bytes returning the default initialisation hash for the chosen algorithm. I thought I had corrected that a long time ago but I may only have done
so for the 'File' tab according to the release notes. That was fixed returning instead 'ZERO BYTE FILE'.

A feature request was made asking for a clearer message when computed hashes do not match expected hash values input
by the user. So a new message dialog is now shown that tries to make it very clear the hashes do or do not match for
single file hashing in the 'File' tab or when using 'drag and drop'.
by the user. So a new message dialog is now shown that tries to make it very clear the hashes do, or do not, match for
single file hashing in the 'File' tab or when using 'drag and drop' feature.

The exe version has been updated to the correct numbering for the version (forgot to update in the project file last time).

The program will now show either "64-bit" or "32-bit" in the title if its 64 or 32 bit accordingly.
The program will now show either "64-bit" or "32-bit" in the main title if its 64 or 32 bit accordingly.

The 'About' dialog has been updated and also re-aligned for word-wrap, to try and make it look neater.

The 'About' menu updated and re-aligned for word-wrap, to try and make it look neater.
The 'About' dialog was showing an incorrect link to the donations page! Corrected to https://paypal.me/quickhashgui


v3.0.2 (Mar 2018)
Expand Down
10 changes: 3 additions & 7 deletions dbases_sqlite.lfm
Expand Up @@ -9,12 +9,12 @@ object frmSQLiteDBases: TfrmSQLiteDBases
OnClose = FormClose
OnCreate = FormCreate
Position = poScreenCenter
LCLVersion = '1.6.4.0'
LCLVersion = '1.8.4.0'
object lblConnectionStatus: TLabel
Left = 32
Height = 13
Height = 15
Top = 32
Width = 72
Width = 81
Caption = 'Not Connected'
ParentColor = False
end
Expand All @@ -27,15 +27,13 @@ object frmSQLiteDBases: TfrmSQLiteDBases
FieldDefs = <>
Database = SQLite3Connection1
Transaction = SQLTransaction1
Options = []
Params = <>
left = 48
top = 80
end
object SQLTransaction1: TSQLTransaction
Active = False
Database = SQLite3Connection1
Options = []
left = 48
top = 224
end
Expand All @@ -44,7 +42,6 @@ object frmSQLiteDBases: TfrmSQLiteDBases
LoginPrompt = False
KeepConnection = False
Transaction = SQLTransaction1
Options = []
left = 48
top = 296
end
Expand All @@ -69,7 +66,6 @@ object frmSQLiteDBases: TfrmSQLiteDBases
FieldDefs = <>
Database = SQLite3Connection1
Transaction = SQLTransaction1
Options = []
Params = <>
left = 160
top = 80
Expand Down
8 changes: 4 additions & 4 deletions dbases_sqlite.pas
Expand Up @@ -792,7 +792,7 @@ procedure TfrmSQLiteDBases.SortByID(DBGrid : TDBGrid);
begin
try
DBGrid.DataSource.Dataset.Close; // <--- we don't use sqlFILES but the query connected to the grid
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize ' +
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize, KnownHashFlag ' +
'FROM TBL_FILES ORDER BY Id';
SQLite3Connection1.Connected := True;
SQLTransaction1.Active := True;
Expand All @@ -811,7 +811,7 @@ procedure TfrmSQLiteDBases.SortByFileName(DBGrid : TDBGrid);
begin
try
DBGrid.DataSource.Dataset.Close; // <--- we don't use sqlFILES but the query connected to the grid
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize ' +
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize, KnownHashFlag ' +
'FROM TBL_FILES ORDER BY FileName';
SQLite3Connection1.Connected := True;
SQLTransaction1.Active := True;
Expand All @@ -831,7 +831,7 @@ procedure TfrmSQLiteDBases.SortByFilePath(DBGrid : TDBGrid);
begin
try
DBGrid.DataSource.Dataset.Close; // <--- we don't use sqlFILES but the query connected to the grid
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize ' +
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize, KnownHashFlag ' +
'FROM TBL_FILES ORDER BY FilePath';
SQLite3Connection1.Connected := True;
SQLTransaction1.Active := True;
Expand All @@ -851,7 +851,7 @@ procedure TfrmSQLiteDBases.SortByHash(DBGrid : TDBGrid);
begin
try
DBGrid.DataSource.Dataset.Close; // <--- we don't use sqlFILES but the query connected to the grid
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize ' +
TSQLQuery(DBGrid.DataSource.Dataset).SQL.Text := 'SELECT Id, Filename, FilePath, HashValue, FileSize, KnownHashFlag ' +
'FROM TBL_FILES ORDER BY HashValue';
SQLite3Connection1.Connected := True;
SQLTransaction1.Active := True;
Expand Down
4 changes: 2 additions & 2 deletions frmaboutunit.lfm
Expand Up @@ -11,7 +11,7 @@ object frmAbout: TfrmAbout
object memAbout: TMemo
Left = 16
Height = 489
Top = 24
Top = 16
Width = 484
Anchors = [akTop, akLeft, akRight, akBottom]
Lines.Strings = (
Expand Down Expand Up @@ -44,7 +44,7 @@ object frmAbout: TfrmAbout
AnchorSideTop.Side = asrBottom
Left = 32
Height = 25
Top = 513
Top = 505
Width = 147
Caption = 'Close'
OnClick = Button1Click
Expand Down
44 changes: 22 additions & 22 deletions frmaboutunit.lrs
Expand Up @@ -4,31 +4,31 @@ LazarusResources.Add('TfrmAbout','FORMDATA',[
'TPF0'#9'TfrmAbout'#8'frmAbout'#4'Left'#3#6#2#6'Height'#3'*'#2#3'Top'#3#138#0
+#5'Width'#3#2#2#7'Caption'#6#19'About QuickHash-GUI'#12'ClientHeight'#3'*'#2
+#11'ClientWidth'#3#2#2#8'Position'#7#16'poMainFormCenter'#10'LCLVersion'#6#7
+'1.8.4.0'#0#5'TMemo'#8'memAbout'#4'Left'#2#16#6'Height'#3#233#1#3'Top'#2#24#5
+'1.8.4.0'#0#5'TMemo'#8'memAbout'#4'Left'#2#16#6'Height'#3#233#1#3'Top'#2#16#5
+'Width'#3#228#1#7'Anchors'#11#5'akTop'#6'akLeft'#7'akRight'#8'akBottom'#0#13
+'Lines.Strings'#1#6'$Developed by Ted Smith (c) 2011-2019'#6#0#6#127'Home Pa'
+'ge : http://www.quickhash-gui.org (First registered in 2011 on Sourceforge '
+'at http://sourceforge.net/projects/quickhash)'#6#0#6#219'Donations are welc'
+'at http://sourceforge.net/projects/quickhash)'#6#0#6#222'Donations are welc'
+'omed! The website is hosted using AWS which is actually quite expensive! If'
+' you have found QuickHash useful to you or your business, please consider d'
+'onating using PayPal at https://paypal.me/quickhash'#6#0#6'FThe development'
+' Github Page is : https://github.com/tedsmith/quickhash'#6#0#6#142'Bug Trac'
+'ker is available at http://www.quickhash-gui.org/bug-tracker/ where bugs an'
+'d feature requests can be submitted, reviewed and tracked. '#6#0#6#244'Cont'
+'ributions made by DaReal Shinji (http://www.github.com/darealshinji), espec'
+'ially regarding repository maintenance and Debian packaging are both welcom'
+'ed and acknowledged, in addition to the Lazarus forum members, who are alwa'
+'ys so helpful. '#6#0#12#20#1#0#0'For a private communication or technical h'
+'elp which the website does not answer, you can e-mail me at tedsmith@quickh'
+'ash-gui.org, however, this should not be used as the means to ask about bug'
+'s or problems. Please use the bug tracker for that so that other users can '
+'benefit. '#6#0#6'QCreated using the Lazarus IDE and the Freepascal Compiler'
+' (www.lazarus-ide.org). '#6#0#6#167'The HashLib4Pascal library is licensed '
+'under MIT and developed by the talented Ugochukwu Mmaduekwe Stanley (aka Xo'
+'r-el - see https://github.com/Xor-el/HashLib4Pascal).'#6#0#6'>QuickHash is '
+'open-source and released under the GPL2 license. '#0#8'ReadOnly'#9#10'Scrol'
+'lBars'#7#10'ssAutoBoth'#8'TabOrder'#2#0#0#0#7'TButton'#7'Button1'#21'Anchor'
+'SideTop.Control'#7#8'memAbout'#18'AnchorSideTop.Side'#7#9'asrBottom'#4'Left'
+#2' '#6'Height'#2#25#3'Top'#3#1#2#5'Width'#3#147#0#7'Caption'#6#5'Close'#7'O'
+'nClick'#7#12'Button1Click'#8'TabOrder'#2#1#0#0#0
+'onating using PayPal at https://paypal.me/quickhashgui'#6#0#6'FThe developm'
+'ent Github Page is : https://github.com/tedsmith/quickhash'#6#0#6#142'Bug T'
+'racker is available at http://www.quickhash-gui.org/bug-tracker/ where bugs'
+' and feature requests can be submitted, reviewed and tracked. '#6#0#6#244'C'
+'ontributions made by DaReal Shinji (http://www.github.com/darealshinji), es'
+'pecially regarding repository maintenance and Debian packaging are both wel'
+'comed and acknowledged, in addition to the Lazarus forum members, who are a'
+'lways so helpful. '#6#0#12#20#1#0#0'For a private communication or technica'
+'l help which the website does not answer, you can e-mail me at tedsmith@qui'
+'ckhash-gui.org, however, this should not be used as the means to ask about '
+'bugs or problems. Please use the bug tracker for that so that other users c'
+'an benefit. '#6#0#6'QCreated using the Lazarus IDE and the Freepascal Compi'
+'ler (www.lazarus-ide.org). '#6#0#6#167'The HashLib4Pascal library is licens'
+'ed under MIT and developed by the talented Ugochukwu Mmaduekwe Stanley (aka'
+' Xor-el - see https://github.com/Xor-el/HashLib4Pascal).'#6#0#6'>QuickHash '
+'is open-source and released under the GPL2 license. '#0#8'ReadOnly'#9#10'Sc'
+'rollBars'#7#10'ssAutoBoth'#8'TabOrder'#2#0#0#0#7'TButton'#7'Button1'#21'Anc'
+'horSideTop.Control'#7#8'memAbout'#18'AnchorSideTop.Side'#7#9'asrBottom'#4'L'
+'eft'#2' '#6'Height'#2#25#3'Top'#3#249#1#5'Width'#3#147#0#7'Caption'#6#5'Clo'
+'se'#7'OnClick'#7#12'Button1Click'#8'TabOrder'#2#1#0#0#0
]);

0 comments on commit 1d024b9

Please sign in to comment.