Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additions to context made by adjust rules for follow-up rules #222

Open
happz opened this issue Feb 27, 2024 · 1 comment
Open
Labels
context enhancement New feature or request

Comments

@happz
Copy link
Collaborator

happz commented Feb 27, 2024

Derived from teemtee/tmt#2706:

adjust:
  - when: distro == rhel-9
    context+:
      llvm: 19

  - when: llvm == 19
    ...

Since fmf does not recognize context, this might need a combined effort of tmt and tmt, e.g. fmf accepting a callback updating context, or a list of keys affecting context...

No idea how messy this can get. Plus, I recall seeing similar questions in the past, there might be issues with discussions somewhere. Yet, it might be nice to give it more thought.

@happz happz added enhancement New feature or request context labels Feb 27, 2024
@happz
Copy link
Collaborator Author

happz commented Feb 27, 2024

Summary from today's hacking meeting:

Order of the evaluation

  • The adjust rules would have to be defined in the right order so that the added context dimension is defined early enough during the adjust rules application (single fmf node can have definition at 3 locations thanks to elasticity)
  • There could be several run-throughs, during the first pass we could just evaluate rules which are modifying the context dimensions
    • This would not work if the expectation is that the changes should be applied to selected fmf subtrees only
    • Changing context for follow-up rules seems to be good enough, no expectation of multiple passes

The original use case seems to be ok with change in the current set of rules only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant