Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled state not persisted #45

Closed
tslocke opened this issue Feb 12, 2023 · 2 comments · Fixed by #47
Closed

Disabled state not persisted #45

tslocke opened this issue Feb 12, 2023 · 2 comments · Fixed by #47

Comments

@tslocke
Copy link

tslocke commented Feb 12, 2023

Previous discussion: https://discuss.prosemirror.net/t/prosemirror-developer-tools-chrome-extension/5154

The chrome extension provides a switch to disable it, so you no longer see the icon, but it seems the disabled state is getting lost.

In the above conversation I was saying that this happens between Chrome sessions, but I've now noticed that the icon definitely does sometimes reappear just on a page reload.
@TeemuKoivisto
Copy link
Owner

👍 all right, I'll see when I have time to fix this and any of the other issues as well

@TeemuKoivisto TeemuKoivisto mentioned this issue Feb 21, 2023
Merged
@TeemuKoivisto
Copy link
Owner

TeemuKoivisto commented Feb 21, 2023 •
edited
Loading

Yeah hah, it never persisted the state in the first place 😅. Wonder how that flied past me. I'll try to get this published soon, but it'll take some time for the new extension version to go live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: actually persist extension state to storage TeemuKoivisto/prosemirror-dev-toolkit
2 participants
@tslocke @TeemuKoivisto