Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Issue: directConnect option not passed in correctly. #105

Open
wawyed opened this issue Feb 6, 2015 · 2 comments
Open

Issue: directConnect option not passed in correctly. #105

wawyed opened this issue Feb 6, 2015 · 2 comments

Comments

@wawyed
Copy link

wawyed commented Feb 6, 2015

directConnect option support was added in this commit.

rubenv@86d2f91

Although, the commit added the option as a string, even though in the protractor docs: https://github.com/angular/protractor/blob/master/docs/referenceConf.js, the option is specified as boolean, so no matter what you set that option is always evaluated to true ( since any non empty string is true ).

@sonata82
Copy link

sonata82 commented May 8, 2015

It's even worse: the current code for reading of parameters prevents any parameter from having the value false:

if (a in opts.args || grunt.option(a)) {
    // this will never happen for options which have a `false` value
    args.push('--'+a, grunt.option(a) || opts.args[a]);
}

@readme42
Copy link

Thats true.

directConnect: false results to
Error: browserName (phantomjs) is not supported with directConnect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants