Unable to change resolution on macOS

[ChillerDragon]

I realized the game looks pretty pixalated so i went to the graphics settings and i wonderd why the resoltion is so low. Then I tried to increase it. But after restart the same option was selected even tho the settings and the console said something different. But the game was still full of pixels and not my screen resultion.

The options always showed 1440x900 after client restart.

[Dune-jr]

@ChillerDragon so your gfx_screen_width says something different?

[ChillerDragon]

@Dune-jr yes

[ChillerDragon]

@Dune-jr oh wait i am not sure the #1660 bug is so confusing

[ChillerDragon]

Ok now i tested it multiple times.
Ingame it always shows the 1440 width and the gfx_screen_width command does the same. Always 1440 (unless you press uparrow to see it agian^^ because #1660).

But when i change it to 2880 it also updates the settings.cfg and the settings.cfg stays at 2880 until the client gets closed then it changes back to 1440.

-->
Seems like writing works but reading fails.

[Dune-jr]

So, if I understand it right, the game reads gfx_screen_width 2880 from settings.cfg, but says "nope" and goes back to 1440.

Maybe try with smaller resolutions? Is it a big resolution only problem?

[oy]

The fullscreen resolution on mac osx is restricted to the desktop resolution. There used to be a bug in sdl when using sth else - i think the game freezes when tabbing out and then back in. Dunno if that's fixed yet.
b81e295 that was the commit.

[ChillerDragon]

@oy i don't know what SDL_WINDOW_FULLSCREEN_DESKTOPis but i normally don't see pixels on my screen.

Yes i realized that the tabbing support has improved a lot c:
But it would be awesome to go with the actual best and screen resoltuion the device has.

[Dune-jr]

Doesn't that require HiDPI support, @ChillerDragon?
#1563 maybe related

[ChillerDragon]

@Dune-jr probably but i complete nobo on that field. I just assumed that the desktop resolution my desktop resolution is xd
And i am also not able to lower it but i guess that makes sense because we found that line that hardcodes the resolution on macOS.

[Dune-jr]

Sounds like #1563

[oy]

Yeah, that's the highdpi problem.

[Dune-jr]

Worth noting @Learath2 worked on it, leading to https://bugzilla.libsdl.org/show_bug.cgi?id=5046

[Learath2]

I want to get this out of the way while looking at SDL issues, @ChillerDragon is this still an issue for you? If so can you debug a little bit for me?