Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by players always takes bots in account #1867

Closed
Dune-jr opened this issue Dec 15, 2018 · 3 comments · Fixed by #1868
Closed

Sorting by players always takes bots in account #1867

Dune-jr opened this issue Dec 15, 2018 · 3 comments · Fixed by #1868
Milestone

Comments

@Dune-jr
Copy link
Member

Dune-jr commented Dec 15, 2018

screenshot_2018-12-15_01-28-23

@nheir
Copy link
Contributor

nheir commented Dec 15, 2018

Should the game hide also bot spectators whatever the spectator filter ?

if(FilterInfo.m_SortHash&IServerBrowser::FILTER_BOTS)
{
Num -= pEntry->m_NumBotPlayers;
Max -= pEntry->m_NumBotPlayers;
if(!(FilterInfo.m_SortHash&IServerBrowser::FILTER_SPECTATORS))
{
Num -= pEntry->m_NumBotSpectators;
Max -= pEntry->m_NumBotSpectators;
}
}

@Dune-jr
Copy link
Member Author

Dune-jr commented Dec 15, 2018

That looks like a bug.

@oy
Copy link
Member

oy commented Dec 15, 2018

@nheir
That's what it does.

int Num = (FilterInfo.m_SortHash&IServerBrowser::FILTER_SPECTATORS) ? pEntry->m_NumPlayers : pEntry->m_NumClients;
initial value.

Fixed by #1868

@oy oy closed this as completed Dec 15, 2018
@oy oy added this to the 0.7.2 milestone Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants