Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute map configs on map change #514

Closed
BotoX opened this issue Mar 8, 2011 · 16 comments
Closed

Execute map configs on map change #514

BotoX opened this issue Mar 8, 2011 · 16 comments

Comments

@BotoX
Copy link

BotoX commented Mar 8, 2011

When map is changed, execute config like map.cfg in data/maps folder.

Example: I change map to ctf2. In my data/maps folder (or in the root directory, whatever) i have my ctf2.cfg. And i want the server to execute this file.

@ghost
Copy link

ghost commented Mar 8, 2011

Why don't you execute the cfg, instead of changing the map?

@BotoX
Copy link
Author

BotoX commented Mar 8, 2011

Because when i have a maprotation and i want the scorelimit on ctf2 to be 500 and on ctf4 1000. I am not every time on the Server so i cant change it. Would be nice to automate it.

@heinrich5991
Copy link
Contributor

Invalid, server automatically executes <mapname_without_.map>.cfg and .cfg on map change.

@ghost
Copy link

ghost commented Mar 10, 2011

Change this issue to: add the possibility to add a cfg into the rotation

@heinrich5991
Copy link
Contributor

Invalid anyway. You can maprotate ctf1 ctf2 ctf3 and create the cfgs ctf1.cfg ctf2.cfg, ctf3.cfg so they will be executed by the maprotation.

@ghost
Copy link

ghost commented Mar 10, 2011

What if you want more than one configuration per map?

@heinrich5991
Copy link
Contributor

Why would you want to have multiply configurations per map?
Example please.

@ghost
Copy link

ghost commented Mar 11, 2011

For example a dm map can be used for tdm and dm.

@heinrich5991
Copy link
Contributor

I don't see a reason for having a server with DM and TDM via maprotation. The gametype on one server should be static, because if I join a server in the server browser with gametype DM, I expect it to be DM, maybe with another map, but with DM :)

@Sworddragon
Copy link
Contributor

You shouldn't expect that the gametype is static. I like the idea from Ubu- to add a configuration for every rotation.

@BotoX
Copy link
Author

BotoX commented Mar 11, 2011

So i tried everything like you said. First created a ctf2.cfg in the data/maps folder. Setted the sv_maprotation ctf4 ctf2. Timelimit is 1. Waited a time the map changed but nothing was executed. Doing the same with config in the root folder of the server, nothing.
And i also can't found that in the Teeworlds source. I am using the newest Trunk version from here.

@heinrich5991
Copy link
Contributor

@BotoX: sorry, i read the code in DDRace and thought it would have been inherited from teeworlds, but it wasn't. Check out #516.

@ghost
Copy link

ghost commented Mar 12, 2011

@ heinrich5991: You aren't really coherent. You are saying that when you join a server, you expect that the gametype won't change. But your pullrequest adds the possibility for admins to automatically change the gametype via a map rotation.

I have a question about your pullrequest: if I callvote for ctf2 and that there is a ctf2.cfg, will it load the ctf2.cfg if the vote suceeds?
If yes, I think it shouldn't be that way. When I vote for a map, I expect that only the map will change. But when I vote for a specific cfg, I expect bigger changes.

@heinrich5991
Copy link
Contributor

It's for map-specifc configurations like scorelimit. That's needed because of the huge difference in sizes of the teeworlds default maps, e.g. ctf1 and ctf5.
I still disapprove with changing the gametype. For scorelimit it is different - since the scorelimit isn't shown in server browser.

@ghost
Copy link

ghost commented Mar 12, 2011

Your own pullrequest adds a way to automatically change the gametype so...

@oy
Copy link
Member

oy commented Apr 2, 2011

Wontfix - a map change should just change the map. Everything else should be done by calling exec in the remote console or via votes.

@oy oy closed this as completed Apr 2, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants