Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Night mode don't apply on PDF #148

Open
Meonthb opened this issue Sep 2, 2023 · 19 comments
Open

[BUG] Night mode don't apply on PDF #148

Meonthb opened this issue Sep 2, 2023 · 19 comments
Assignees
Labels
bug Something isn't working

Comments

@Meonthb
Copy link

Meonthb commented Sep 2, 2023

Describe the bug
Night mode don't apply on PDF in Zotero 7

To Reproduce
Steps to reproduce the behavior:
Toggled the night mode icon, only the UI turned into dark, but not the PDF.

Screenshots
image

OS (MacOS XX.xx [specify Intel or Silicon], Windows, Linux [specify distro/package type]:
Windows 11
version: 22H2
OS build: 22621.2215
Experience: Windows Feature Experience Pack 1000.22662.1000.0

@Meonthb Meonthb added the bug Something isn't working label Sep 2, 2023
@Meonthb Meonthb changed the title [BUG] [BUG] Night mode don't apply on PDF Sep 2, 2023
@tefkah
Copy link
Owner

tefkah commented Sep 5, 2023

Are you using the latest version of the plugin? The first release for Zotero 7 had that problem

@Meonthb
Copy link
Author

Meonthb commented Sep 5, 2023

Are you using the latest version of the plugin? The first release for Zotero 7 had that problem

Yes, I'm using the latest version 0.1.0-1
image

@tefkah
Copy link
Owner

tefkah commented Sep 5, 2023

thanks for double checking! this might be a windows version problem then, which is kind of hard for me to check. If other people have this problem on Windows 11 please let me know!

@tefkah
Copy link
Owner

tefkah commented Sep 5, 2023

Oh and which version of Zotero are you running?

@Meonthb
Copy link
Author

Meonthb commented Sep 5, 2023

Thank you for your work! I'm using the latest Zotero version 7.0.0-beta.39+ecba25be0 (64-bit)

@sleepymalc
Copy link

I do encounter the same bug. Every time I open a new pdf, it appears in a light theme (only for pdf; the rest of the UI is still in dark mode). I'll need to manually toggle the theme switch to make the pdf appear in the dark mode.

@FlynnSpace
Copy link

I get this situation too, when I open a pdf, it's still light, but the sidebar is dark. I try to find the button to change it, but it seems the button is missing XD
image

@tefkah
Copy link
Owner

tefkah commented Sep 12, 2023

@FlynnSpace Seems like you are using the Zotero 6 version, what version of the plugin of the plugin are you using?

@tefkah
Copy link
Owner

tefkah commented Sep 12, 2023

For the people on Zotero 7, please try the latest release

@FlynnSpace
Copy link

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

@jiagengliu
Copy link

I had the same problem on mac, but restarting Zotero solved the problem.

@zgz292dev
Copy link

I have the same problem on Windows 11. OS build : 22621.228

@kzssc
Copy link

kzssc commented Sep 24, 2023

Mac 13.5.2
Night 0.1.0-2 2023-09-12 11:55:51
7.0.0-beta.40+24ae34104

Can confirm that sometimes dark mode works for some PDF, but not all.
This can be rectified by closing the document and then re-open from within Zotero. Re-opening Zotero does not rectify the issue.

@csy94cfy
Copy link

csy94cfy commented Oct 7, 2023

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

@franzbischoff
Copy link

franzbischoff commented Oct 11, 2023

Mac 13.5.2 Night 0.1.0-2 2023-09-12 11:55:51 7.0.0-beta.40+24ae34104

Can confirm that sometimes dark mode works for some PDF, but not all. This can be rectified by closing the document and then re-open from within Zotero. Re-opening Zotero does not rectify the issue.

For me, some PDFs get dark.
After some trials, seems to be related to the initial state of the "light/dark" button when you open the PDF. If you switch back to the star, close the pdf, reopen the pdf, then click again ob the button, it cycle light and dark correctly.

Again, some times it does not work like I said... then I kept the PDF opened, switch off the addon and on again, and voilá, dark... :-/

@FlynnSpace
Copy link

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

No, the background of all my PDFs still stings the eyes, even if I restart the plugin or Zetero. (╯ ͡❛ ͜ʖ ͡❛)╯┻━┻

@franzbischoff
Copy link

@tefkah The plugin is 0.4.23 and the Zotero is 6.0.27. Should I download the old version plugin or Zotero?

hey dude, I have the same versions as you, have you solved your question?

No, the background of all my PDFs still stings the eyes, even if I restart the plugin or Zetero. (╯ ͡❛ ͜ʖ ͡❛)╯┻━┻

Try the "disable/enable" trick while not fixed :)

@FlynnSpace
Copy link

@csy94cfy hey bro, I think I found the alternative solution from issue #128 . You can try the plugin "zotero-style", which is able to set the PDF's background to dark.

@ruturajreddy
Copy link

For me it worked by going to Tools -> Night preferences and enabling disabling the option for dark mode and selecting the option for the default pdf view. Working on Zotero 6.0.37.

This is what it should look like.
Screenshot 2024-04-02 at 5 30 12 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants