Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not exit on SIGINT if web client is connected #98

Open
wchill opened this issue Jul 27, 2016 · 0 comments
Open

Does not exit on SIGINT if web client is connected #98

wchill opened this issue Jul 27, 2016 · 0 comments
Labels

Comments

@wchill
Copy link
Contributor

wchill commented Jul 27, 2016

Expected Behavior

Bot exits when SIGINT is fired.

Actual Behavior

Exiting PokemonGo Bot is printed but nothing happens until all clients connected to the web server plugin exit.

Steps to Reproduce

  • After the web plugin is loaded, open up the webview in a browser
  • Without closing browser, send SIGINT with Ctrl+C or some other method

Can probably be fixed by firing an event when the bot is going to shut down, allowing plugins to clean up their state. Alternatively, force the program to exit by installing a SIGINT handler.

@wchill wchill added the bug label Jul 27, 2016
@meyer9 meyer9 self-assigned this Aug 13, 2016
@tehp tehp unassigned meyer9 Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants