Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate references to node modules #107

Closed
TehShrike opened this issue May 22, 2017 · 2 comments
Closed

Eliminate references to node modules #107

TehShrike opened this issue May 22, 2017 · 2 comments

Comments

@TehShrike
Copy link
Owner

Use https://github.com/michaelrhodes/iso-next-tick instead of process.nextTIck
Use https://www.npmjs.com/package/eventemitter3 instead of `events

There's no reason to make life bad for non-browserify-bundlers
TehShrike added a commit that referenced this issue May 22, 2017
@TehShrike
Use iso-next-tick instead of process.nextTick
d8181e7 
#107
@TehShrike
Copy link
Owner Author

Should be fixed by d8181e7 and ea78e3a and #105

@TehShrike
Copy link
Owner Author

Published as 5.16.2. When bundling with browserify, the (unminified) output drops from 88,878 bytes to 62,373 bytes, thanks in large part to dropping the Array.prototype.find polyfill from hash-brown-router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TehShrike