-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using root path '/' the page doesn't render on refresh #116
Comments
Is the Is the router emitting a What is the url when you refresh? If you wipe out the hash fragment and refresh, does it behave differently? |
evaluateCurrent is pointing to 'login'. routeNotFound is not being fired. If I manually remove the hash from the url and refresh it works. |
It's pretty easy to recreate, just update this line to point to '/' |
And load what url?
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Robert Balfre <notifications@github.com>
Sent: Wednesday, November 15, 2017 8:04:05 PM
To: TehShrike/abstract-state-router
Cc: Josh Duff; Comment
Subject: Re: [TehShrike/abstract-state-router] When using root path '/' the page doesn't render on refresh (#116)
It's pretty easy to recreate, just update this line<https://github.com/TehShrike/state-router-example/blob/efa9f57c4bf436c2379d7aa562874699a6e82a8a/implementations/svelte/login/login.js#L7> to point to '/'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#116 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABFsbQdo_12cO8k4E58EFcc-535AvEVHks5s25gVgaJpZM4QfwGv>.
|
mm, I was able to reproduce. It looks like |
It's a bug in hash-brown-router :-o |
When the current route was `/` and you would call `evaluateCurrent('/')`, nothing would happen. Reported in TehShrike/abstract-state-router#116 Bug added in #08f93795
…-not-working-on-slash-route Failing test for #116
Published as 6.0.4. |
I confirmed that it works with that change to Thanks for reporting! 👍 |
@TehShrike awesome thanks |
I'm trying to add a home '/' route to my app (using svelte-state-renderer). I've used the examples over on state-router-example as a base but when I change the route in login.js from 'login' to '/' or an empty string the page is blank on refresh.
The text was updated successfully, but these errors were encountered: