Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get browserstack tests passing again #86

Closed
TehShrike opened this issue Aug 19, 2016 · 1 comment
Closed

Get browserstack tests passing again #86

TehShrike opened this issue Aug 19, 2016 · 1 comment

Comments

@TehShrike
Copy link
Owner

Thanks to some help from another dev, browserstack tests report their results much more reliably now. I've updated package.json to use the better versions. a3a62f8

It looks like some tests aren't passing any more, most notably the webpack test that tries to read from disc. We should have some difference between node tests and browser tests so that that test doesn't get loaded.

I'm not sure why some of those other tests aren't passing (I saw one about console.error not being a function in Chrome, which it totally is). It would probably be easier to make sure everything passes with tape-run first.

@TehShrike
Copy link
Owner Author

I've given up on Browserstack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant