Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions not merged #23

Closed
dannyshaw opened this issue Oct 22, 2015 · 0 comments · Fixed by #30
Closed

Regular expressions not merged #23

dannyshaw opened this issue Oct 22, 2015 · 0 comments · Fixed by #30
Labels

Comments

@dannyshaw
Copy link

Apologies if this is expected behavior but I am not seeing regular expressions come through merges.
Seeing the following behavior in 0.2.10 fresh install from npm

var deepmerge = require('deepmerge');

var obj1 = {
  test: /\.js?$/,
}

var obj2 = {
  test: /\.jsx?$/,
}

console.log(obj1.test.test('file.js'));
console.log(obj2.test.test('file.jsx'));

var result = deepmerge(obj1, obj2);

console.log(result.test.test('file.js'));
console.log(result.test.test('file.jsx'));
$ node deepmergetest.js 
true
true
/home/danny/bm/pub/scratch/deepmergetest.js:18
console.log(result.test.test('file.js'));
                        ^
TypeError: undefined is not a function
    at Object.<anonymous> (/home/danny/bm/pub/scratch/deepmergetest.js:18:25)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3
@TehShrike TehShrike added the bug label Sep 27, 2016
TehShrike added a commit that referenced this issue Sep 27, 2016
- Extra test for #18
- Some bugs similar to #23 and #31 where regexes and dates wouldn't be copied correctly across arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants