[feat] NFT.storage continue... #159

melMass · 2022-08-12T12:00:06Z

Fixing issues due to the IPFS switch and older unreported ones:

Cannot edit profile
- Works but there is absolutely no feedback...
MD preview / styling -> fixed displayURi issue, styling should be done is a dedicated PR
Subfolders for generative tokens (linked to fix: ⚡️ use nft.storage directory API ipfs-upload-proxy#3)
~~Clean the folders before upload? (macOS creates .DS_Store files and ._. prefixed files, windows has ThumbDB), might be "dangerous" to alter the archive~~

render · 2022-08-12T12:00:10Z

Your Render PR Server URL is https://teia-ui-pr-159.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbr41i4gqg4boe46nbj0.

melMass · 2022-08-12T13:21:12Z

I was about to remove every instance of IPFS as we use various gateways.
@NoRulesJustFeels while doing that I wonder if this won't make reaching gateways limits faster?

For now I just changed the SUBJKT icon (was DWEB -> IPFS.io), keeping the current gateway used by others, we can switch easily once we decide

Also add NFTStorage as suggested by NRJF in #150.

NoRulesJustFeels · 2022-08-12T13:30:06Z

As part of the discussion on #150, there are various IPFS options to consider. We should probably spend some time testing those when we have access. We might even consider some kind of failover solution for the client if the rate limit is reached for a particular gateway.

melMass · 2022-08-12T13:31:50Z

As part of the discussion on #150, there are various IPFS options to consider. We should probably spend some time testing those when we have access. We might even consider some kind of failover solution for the client if the rate limit is reached for a particular gateway.

I was not up to date with that issue! Awesome

This was setting a .gravatar property to the parsed metadatafile. Does not make sense and is not used anywhere.

The optional second param for HashToURL and CIDToURL allows you to override the IPFS gateway to use.

- use const where it makes sense (easier to read) - fixed the getBalance function even if it should not be there... - added a fetchJSON util function.

melMass · 2022-08-13T01:18:04Z

Added a few things:

Check the balance on the mint page: This displays if you have less than 0.15Tz (6Tz for the screenshot)
Check for existing SUBJKT: This is an ongoing issue people had as there is no check before making the contract call so it only failed in Temple/Kukai not before. Now it's showing the owner of the name:
Replaced alert() with the context feedback:
All IPFS CIDs and Hashes now use dedicated util functions shared across to convert them to http gateway links. The second argument to specify the gateway is optional and by default uses a new dedicated ENV Variable (REACT_APP_IPFS_DEFAULT_GATEWAY). A few different gateways (DWeb, Cloudflare, Ipfs.io, Infura) where used before.

Seems to fix #110, but still unexplained...

fixes #160

melMass · 2022-08-16T16:18:22Z

Ah ok... The CI is not building to the stage URL since quite a few commits, related to this somehow even if we use npm everywhere
dilanx/craco#435

Adding typescript as a dev dependency. This is a bug upstream in craco: dilanx/craco#435

xat

left a few comments, nothing dramatic :)

xat · 2022-08-17T18:02:05Z

jsconfig.json

@@ -1,14 +1,18 @@
 {


out of interest: why the changes here?

src/components/collab/show/CollabDisplay.js

src/components/media-types/html/index.js

src/components/media-types/index.js

src/components/media-types/video/index.js

src/constants.js

xat · 2022-08-17T18:40:44Z

src/pages/config/index.js

      const buffer = Buffer.from(await file.arrayBuffer())
-      console.log(buffer)
-      this.setState({ identicon: 'ipfs://' + (await ipfs.add(buffer)).path })
+      const picture_cid = await uploadFileToIPFSProxy({


i'm not sure, but can't file just be passed directly to uploadFileToIPFSProxy?

Probably!

This was a bit of the trouble in this PR, that's why I roughly typed it @typedef { {path: string?, blob: Blob} } FileHolder, extracting it from the old code and it's usage mainly to make sense of the code. I would happily clean it further in a separate branch/PR later

ok, yeah, no need that we need to block merging this pr because of that.

xat · 2022-08-17T18:45:33Z

src/pages/objkt-display/index.js

@@ -125,6 +127,36 @@ export const ObjktDisplay = () => {
  }, [])

  const Tab = TABS[tabIndex].component
+
+  const objkt_classes = []


i think this needs to be put in useState.

Isn't making the useEffect depend on nft alleviates that?

I've done all besides this as I'm not sure ;)

hmm, well, if it works, it works :)

as soon as you add something async to the effect, it will probably break though.

melMass · 2022-08-18T00:44:42Z

left a few comments, nothing dramatic :)

Thank youu, making the edits now!

xat · 2022-08-19T14:25:54Z

i manually tested the "Cannot edit profile" fix, it worked 👍

if there is nothing left otherwise, i can merge.

melMass · 2022-08-19T14:28:18Z

i manually tested the "Cannot edit profile" fix, it worked 👍

if there is nothing left otherwise, i can merge.

Yep it solves a few important things like subfolders for generative and profile editing. Further edits can be made in another one ;)

xat

great work!

melMass added 4 commits August 12, 2022 14:30

fix: ⚡️ use MIMETYPES everywhere

4c8338f

fix: ⚡️ jsconfig

6515ff2

fix: ⚡️ move function to utils

a7f6e29

fix: ⚡️ wip remove all references to Infura

15c5184

melMass force-pushed the mel/fix/nft-storage-continue branch from 801abdb to 15c5184 Compare August 12, 2022 12:30

melMass linked an issue Aug 12, 2022 that may be closed by this pull request

[bug] there's a call to infura ipfs left in the config section #158

Closed

melMass added 3 commits August 12, 2022 15:06

fix: 🎨 prevent uploading broken meta

354e068

fix: ⚡️ further removing of infura instances

53b5b9e

fix: ⚡️ wip use HashToURL everywhere

f9d60d8

melMass added 2 commits August 12, 2022 15:25

fix: 🎨 build error

f9731f4

Also add NFTStorage as suggested by NRJF in #150.

fix: ⚡️ use CIDtoURL

a37e716

fix: ⚡️ imports

efdd92b

melMass force-pushed the mel/fix/nft-storage-continue branch from 6393ea5 to efdd92b Compare August 12, 2022 13:39

melMass added 5 commits August 12, 2022 15:44

fix: ⚡️ wrong and not used

c221709

This was setting a .gravatar property to the parsed metadatafile. Does not make sense and is not used anywhere.

fix: ⚡️ use an env variable to set the IPFS gateway

b083858

The optional second param for HashToURL and CIDToURL allows you to override the IPFS gateway to use.

fix: ⚡️ subjkt feedback

429ff8e

fix: ⚡️ context

0e65fc1

- use const where it makes sense (easier to read) - fixed the getBalance function even if it should not be there... - added a fetchJSON util function.

feat: 🔥 warn if balance is low on mint

d526ffe

melMass linked an issue Aug 13, 2022 that may be closed by this pull request

[feat] add error reporting when the SUBJKT is already registered #5

Closed

melMass added 6 commits August 13, 2022 03:49

fix: ⚡️ fetch more token in the batch

eb13332

Seems to fix #110, but still unexplained...

fix: 🎨 add (optional) to optional fields

e4caf7d

fix: ⚡️ use showfeedback, fix fields

3b72abe

fix: ✨ reformat debug logs to take less space

63cad0e

fix: ⚡️ avoid the warning glitch on first mount

8965e28

fix: ⚡️ use showFeedback

4026afd

fix: ⚡️ prepare for v6 with fallback for v5

fc103e2

fixes #160

melMass force-pushed the mel/fix/nft-storage-continue branch from 94ad636 to fc103e2 Compare August 15, 2022 21:26

feat: ⚡️ add long form description

c15e36f

melMass added 3 commits August 16, 2022 18:30

fix: ⚡️ CI Builds

254c7c7

Adding typescript as a dev dependency. This is a bug upstream in craco: dilanx/craco#435

test: ⚡️ use nft.storage gateway (temp)

7bfb674

fix: 🎨 use hash instead of cid method

bbdfa78

xat reviewed Aug 17, 2022

View reviewed changes

fix: ⚡️ xat feedbacks

1ec0ffe

xat approved these changes Aug 19, 2022

View reviewed changes

xat merged commit 1c387d9 into main Aug 19, 2022

xat deleted the mel/fix/nft-storage-continue branch August 19, 2022 14:30

Zir0h mentioned this pull request Aug 26, 2022

[bug] collab settings change doesn't prompt wallet #162

Closed

melMass linked an issue Aug 26, 2022 that may be closed by this pull request

[bug] collab settings change doesn't prompt wallet #162

Closed

melMass mentioned this pull request Aug 28, 2022

[feat] Use the nft.storage IPFS gateway #150

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] NFT.storage continue... #159

[feat] NFT.storage continue... #159

melMass commented Aug 12, 2022 •

edited

render bot commented Aug 12, 2022

melMass commented Aug 12, 2022

NoRulesJustFeels commented Aug 12, 2022

melMass commented Aug 12, 2022

melMass commented Aug 13, 2022 •

edited

melMass commented Aug 16, 2022

xat left a comment

xat Aug 17, 2022

xat Aug 17, 2022

melMass Aug 18, 2022

xat Aug 18, 2022

xat Aug 17, 2022

melMass Aug 18, 2022

melMass Aug 18, 2022

xat Aug 18, 2022

melMass commented Aug 18, 2022

xat commented Aug 19, 2022

melMass commented Aug 19, 2022

xat left a comment

[feat] NFT.storage continue... #159

[feat] NFT.storage continue... #159

Conversation

melMass commented Aug 12, 2022 • edited

render bot commented Aug 12, 2022

melMass commented Aug 12, 2022

NoRulesJustFeels commented Aug 12, 2022

melMass commented Aug 12, 2022

melMass commented Aug 13, 2022 • edited

Added a few things:

melMass commented Aug 16, 2022

xat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melMass commented Aug 18, 2022

xat commented Aug 19, 2022

melMass commented Aug 19, 2022

xat left a comment

Choose a reason for hiding this comment

melMass commented Aug 12, 2022 •

edited

melMass commented Aug 13, 2022 •

edited