Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡develop/layout #227

Merged
merged 41 commits into from Jan 24, 2023
Merged

⚡develop/layout #227

merged 41 commits into from Jan 24, 2023

Conversation

melMass
Copy link
Member

@melMass melMass commented Dec 24, 2022

preview url

Are the tasks already solved in this PR
🚧 Are the tasks in progress that will get done by early January.


  • ✅ Reworked the Header logic, I still have to move things around, but it made the migration of the PR too complex, I will push these next week.

  • ✅ Created a dedicated DropDownButton and DropDownMenu component, used by the new events menu and filters menu.

  • ✅ Masonry & Single view mode switches

  • ✅ Reworked the menu logic and separated it to be reusable in the footer

  • 🚧 OBJKT History, @xat added the "transfer" transaction type but we need an icon for it.

  • 🚧 Zen Mode: The logic is there, it just need to be hooked (context + localStorage I think, like the feed view mode)

  • 🚧 New Footer, it should be inlined on pages with finite scroll (profiles, config, faq etc..) and based on scroll for the infinite feeds?

  • Homogenise the codebase and split components logic;

    • ✅ Removed a bunch of non needed nesting and classes.
    • 🚧Use container queries where it makes sense
    • ✅ Separate Components and Atoms (atom < component < page)

ℹ️ - The fonts are the right ones (named the same as in Figma) but don't look the same, I will check later with @denscimonk


Out of grant

  • 🚧 Created a Hook to manage localStorage settings, only the view mode is used for now. It would be nice to also have a separated key for the "profile" feeds and the other feeds too.
  • 🚧 Advanced filters: only the atomic UI is implemented, the whole logic will be the most important task of January imo.

@melMass melMass changed the base branch from main to teztok-integration December 24, 2022 22:47
Mel Massadian and others added 23 commits January 23, 2023 23:01
Co-authored-by: Mel Massadian <mel@melmassadian>
- Use props instead of a component for curate (with clearer naming)
- Removed non needed context use
- Update stylekit from Figma
To conform to CRA's LocalIdent resolver. i.e use the parent folder name.
This results in prettier build classnames
The idea is to progressively strip the main context.
- on going stripping of the main context, theme is now in localstorage
- reduce nesting and inverted logical comparaisons
- zen, viewmode and theme are now in localStorage (context synce with LS)
- remove loadable for the most viewed components
For zen & view mode respectively
⚠️ Removes url param support (commented out for now...)
@xat xat merged commit 1b6f576 into teztok-integration Jan 24, 2023
@xat xat deleted the mel-clean-develop branch January 24, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants