New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡develop/layout #227
Merged
Merged
⚡develop/layout #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melMass
force-pushed
the
mel-clean-develop
branch
from
December 24, 2022 23:12
f2fb4e0
to
237aac4
Compare
melMass
force-pushed
the
mel-clean-develop
branch
from
December 24, 2022 23:30
237aac4
to
6ef28ba
Compare
melMass
force-pushed
the
mel-clean-develop
branch
from
December 26, 2022 03:46
62e1d2f
to
1d19b60
Compare
Co-authored-by: Mel Massadian <mel@melmassadian>
- Use props instead of a component for curate (with clearer naming) - Removed non needed context use - Update stylekit from Figma
To conform to CRA's LocalIdent resolver. i.e use the parent folder name. This results in prettier build classnames
The idea is to progressively strip the main context.
- on going stripping of the main context, theme is now in localstorage - reduce nesting and inverted logical comparaisons - zen, viewmode and theme are now in localStorage (context synce with LS)
- remove loadable for the most viewed components
For zen & view mode respectively⚠️ Removes url param support (commented out for now...)
Mostly untouched and just typed, parm names where confusing. This will make cleaning it all easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview url
✅ Are the tasks already solved in this PR
🚧 Are the tasks in progress that will get done by early January.
✅ Reworked the Header logic, I still have to move things around, but it made the migration of the PR too complex, I will push these next week.
✅ Created a dedicated DropDownButton and DropDownMenu component, used by the new events menu and filters menu.
✅ Masonry & Single view mode switches
✅ Reworked the menu logic and separated it to be reusable in the footer
🚧 OBJKT History, @xat added the "transfer" transaction type but we need an icon for it.
🚧 Zen Mode: The logic is there, it just need to be hooked (context + localStorage I think, like the feed view mode)
🚧 New Footer, it should be inlined on pages with finite scroll (profiles, config, faq etc..) and based on scroll for the infinite feeds?
Homogenise the codebase and split components logic;
ℹ️ - The fonts are the right ones (named the same as in Figma) but don't look the same, I will check later with @denscimonk
Out of grant