Merge pull request #726 from geraldcombs/master

Add Wireshark to the Qt application list.
pqrs-org · Oct 30, 2016 · 9b8ed20 · 9b8ed20
2 parents d06e183 + 3093b2d
commit 9b8ed20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -2,7 +2,7 @@
 
 * Prepared settings have been updated.
 * Fixed issues:
-  * Some Qt apps might be crash when AXNotifier is enabled. (VirtualBox, LyX)
+  * Some Qt apps might be crash when AXNotifier is enabled. (LyX, VirtualBox, Wireshark)
 
 
 # Version 10.21.0

diff --git a/src/util/AXNotifier/Karabiner_AXNotifier/Classes/AXApplicationObserver.m b/src/util/AXNotifier/Karabiner_AXNotifier/Classes/AXApplicationObserver.m
@@ -150,10 +150,12 @@ - (void)observe {
   }
 
   // Qt apps will be crashed if observe.
+  // See https://bugreports.qt.io/browse/QTBUG-49907
   if (axNotifierPreferencesModel.disabledInQtApps) {
     if ([[[self.runningApplication bundleIdentifier] lowercaseString] hasPrefix:@"com.buhldata."] ||
         [[self.runningApplication bundleIdentifier] hasPrefix:@"org.virtualbox."] ||
         [[self.runningApplication bundleIdentifier] isEqualToString:@"org.lyx.lyx"] ||
+        [[[self.runningApplication bundleIdentifier] lowercaseString] isEqualToString:@"org.wireshark.wireshark"] ||
         false) {
       observable = NO;
     }